From 10ecb6776b1aab0798bed3d63f1563123fc75fab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Minelli?= <git@minelli.me> Date: Fri, 19 Apr 2024 22:42:59 +0200 Subject: [PATCH] Sonar => Remove code smells --- ExerciseChecker/eslint.config.mjs | 1 + ExerciseChecker/package.json | 34 +++++++++++++++-------------- ExerciseChecker/src/app.ts | 2 +- ExerciseChecker/src/shared | 2 +- ExerciseChecker/src/sharedByClients | 2 +- 5 files changed, 22 insertions(+), 19 deletions(-) diff --git a/ExerciseChecker/eslint.config.mjs b/ExerciseChecker/eslint.config.mjs index ca40422..dd4f225 100644 --- a/ExerciseChecker/eslint.config.mjs +++ b/ExerciseChecker/eslint.config.mjs @@ -21,5 +21,6 @@ export default tseslint.config({ '@typescript-eslint/no-unsafe-member-access': 'off', '@typescript-eslint/require-await': 'off', '@typescript-eslint/restrict-template-expressions': 'off', + '@typescript-eslint/no-floating-promises': 'off', } }); \ No newline at end of file diff --git a/ExerciseChecker/package.json b/ExerciseChecker/package.json index 65da0ab..916b8f9 100644 --- a/ExerciseChecker/package.json +++ b/ExerciseChecker/package.json @@ -30,22 +30,24 @@ "test" : "echo \"Error: no test specified\" && exit 1" }, "dependencies" : { - "@dotenvx/dotenvx" : "^0.34.0", - "@gitbeaker/rest" : "^40.0.3", - "axios" : "^1.6.8", - "boxen" : "^5.1.2", - "chalk" : "^4.1.2", - "form-data" : "^4.0.0", - "fs-extra" : "^11.2.0", - "http-status-codes" : "^2.3.0", - "json5" : "^2.2.3", - "ora" : "^5.4.1", - "tar-stream" : "^3.1.7", - "winston" : "^3.13.0", - "winston-transport" : "^4.7.0", - "yaml" : "^2.4.1", - "zod" : "^3.22.5", - "zod-validation-error": "^3.1.0" + "@dotenvx/dotenvx" : "^0.34.0", + "@gitbeaker/core" : "^40.0.3", + "@gitbeaker/requester-utils": "^40.0.3", + "@gitbeaker/rest" : "^40.0.3", + "axios" : "^1.6.8", + "boxen" : "^5.1.2", + "chalk" : "^4.1.2", + "form-data" : "^4.0.0", + "fs-extra" : "^11.2.0", + "http-status-codes" : "^2.3.0", + "json5" : "^2.2.3", + "ora" : "^5.4.1", + "tar-stream" : "^3.1.7", + "winston" : "^3.13.0", + "winston-transport" : "^4.7.0", + "yaml" : "^2.4.1", + "zod" : "^3.22.5", + "zod-validation-error" : "^3.1.0" }, "devDependencies": { "@types/fs-extra" : "^11.0.4", diff --git a/ExerciseChecker/src/app.ts b/ExerciseChecker/src/app.ts index 4b6176e..5bacb02 100644 --- a/ExerciseChecker/src/app.ts +++ b/ExerciseChecker/src/app.ts @@ -167,7 +167,7 @@ async function displayResults() { } -void (async () => { +(async () => { HttpManager.registerAxiosInterceptor(); console.log(Styles.APP_NAME(`${ Config.appName } (version {{VERSION}})`)); diff --git a/ExerciseChecker/src/shared b/ExerciseChecker/src/shared index 771f8cd..c2afa86 160000 --- a/ExerciseChecker/src/shared +++ b/ExerciseChecker/src/shared @@ -1 +1 @@ -Subproject commit 771f8cd079b39ec4050c5ece024dc4d70f342529 +Subproject commit c2afa861bf6306ddec79ffd465a4c7b0edcd3453 diff --git a/ExerciseChecker/src/sharedByClients b/ExerciseChecker/src/sharedByClients index 8514d5e..4256114 160000 --- a/ExerciseChecker/src/sharedByClients +++ b/ExerciseChecker/src/sharedByClients @@ -1 +1 @@ -Subproject commit 8514d5ef589a8aa34e4d2260c618781d81368c22 +Subproject commit 4256114048734c2708436cc8505abecdf62fe6df -- GitLab