Skip to content
Snippets Groups Projects

Resolve "add makefile with structure"

Merged tom.ryser requested to merge 3-add-makefile-with-structure into main
3 unresolved threads

Closes #3 (closed)

Edited by tom.ryser

Merge request reports

Approval is optional

Merged by orestis.malaspinorestis.malaspin 3 years ago (Dec 2, 2021 9:00am UTC)

Merge details

  • Changes merged into main with 42523a25 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • While I understand the reason you want split things between include and source I don't think it makes much sense here.

    Also keep the Makefile simple for the time being. Overcomplicating things from day one may cause sad problems in the long term.

    What I suggest at the moment is have a simpler structure:

    stack.h stack.c main.c

    at the root.

    Also adding so many defaults to the .gitignore is probably too much for a collaborative project. Keep things simple and avoid huge defaults.

  • tom.ryser unapproved this merge request

    unapproved this merge request

  • tom.ryser added 4 commits

    added 4 commits

    Compare with previous version

  • tom.ryser added 1 commit

    added 1 commit

    Compare with previous version

  • tom.ryser resolved all threads

    resolved all threads

  • tom.ryser marked this merge request as draft

    marked this merge request as draft

  • tom.ryser marked this merge request as ready

    marked this merge request as ready

  • tom.ryser added 4 commits

    added 4 commits

    Compare with previous version

  • Author Developer

    I used a simpler Makefile, changed the main return with EXIT_SUCCESS and modified the file and folder structure.

  • tom.ryser added 1 commit

    added 1 commit

    Compare with previous version

  • tom.ryser resolved all threads

    resolved all threads

  • tom.ryser added 1 commit

    added 1 commit

    Compare with previous version

  • tom.ryser removed DONE label

    removed DONE label

  • main.c 0 → 100644
    1 #include <stdio.h>
    2 #include "../include/stack.h"
  • Makefile 0 → 100644
    1 CC:=gcc
    2 CFLAGS:= -g -Wextra -pedantic -fsanitize=address
    3 NAME:=stack
    4
    5 $(NAME): main.o $(NAME).o
    6 $(CC) $(CFLAGS) -o $@ $^ -lSDL2
  • Makefile 0 → 100644
    1 CC:=gcc
    2 CFLAGS:= -g -Wextra -pedantic -fsanitize=address
  • @tom.ryser une dernière souffrance?

  • orestis.malaspin added 25 commits

    added 25 commits

    Compare with previous version

  • added 1 commit

    • 18d33345 - fixed makefile, main compilation and test compilation

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • mentioned in commit 42523a25

  • Please register or sign in to reply
    Loading