add function stack_push

just like the tittle. Thanks for the review. ;D

requested review from @orestis.malaspin

assigned to @richarda.tyarks

The capacity is never changed. I expect this to cause problems.

changed this line in version 2 of the diff

Also if you could merge with main and correct conflicts this would help me.

@richarda.tyarks pleeaaaaaase?

added 28 commits

• 66130f6e...42523a25 - 27 commits from branch main
• da2c2fb5 - Merge branch 'main' into '5-add-push-function'

Compare with previous version

added 1 commit

• 5401bb7f - change variable name val into value in function : stack_push

Compare with previous version

approved this merge request

unapproved this merge request

added 1 commit

• 4ad268aa - remove warning message

Compare with previous version

Sorry Sir, I completely forgot to see your review, since I never check my student mailbox. Sorry again ^^ '

@orestis.malaspin

looks like stack.h is not in the file anymore

this one is still not solved @richarda.tyarks a real jedi would include stack.h there...

done

@richarda.tyarks a little effort to finish

added 1 commit

• 6b2c9fc5 - add realloc in stack_push

Compare with previous version

@orestis.malaspin finish sir.

Almost young padawan. Capacity is never changed!

added 1 commit

• cac83986 - capacity is never changed

Compare with previous version

noooooooooooooooooooooooooo.....

we want to allocate twice the current capacity. and also change the capacity variable inside the struct. don't we?

if (s->top == DEFAULT_CAPACITY-1) { assert(s->data = realloc(s->capacity * 2 * sizeof(int))); } like that ? but in this case we can enlarge the stack only once ?

No no.

What I mean is that you have to reallocate to twice the CURRENT capacity. Then change the capacity variable too.

In this example you:

1. Change the capacity of data only once for all (when top == DEFAULT_CAPACITY-1 which happens only once if you continuously push).
2. Never change the capacity variable in your stack.

haaaaa yes it's just add "s->capacity=s->capacity * 2;" after the realloc for update the new capacity limit

added 1 commit

• a7479039 - now i can feel the force

Compare with previous version

added 1 commit

• 515a3006 - https://www.youtube.com/watch?v=dQw4w9WgXcQ

Compare with previous version

Ce rick roll....

mentioned in commit 287ed7af

merged

mentioned in issue #5 (closed)