Merge branch 'typescript_eslint' into v3.1.0

AssignmentChecker/.eslintignore

+dist
+node_modules
+.gitlab-ci
\ No newline at end of file

AssignmentChecker/.eslintrc.json

+{
+    "root"   : true,
+    "parser" : "@typescript-eslint/parser",
+    "plugins": [
+        "@typescript-eslint"
+    ],
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended"
+    ]
+}
\ No newline at end of file

AssignmentChecker/.gitlab-ci/03_stages.yml

 stages:
+    - code_quality
     - test
     - build
     - clean

AssignmentChecker/.gitlab-ci/04_stageCodeQuality.yml

+code_quality:lint:
+    stage: code_quality
+    tags:
+        - code_quality
+    image: node:latest
+    script:
+        - cd "${PROJECT_FOLDER}"
+        
+        - npm install
+        - npm run lint

jetbrainsConfiguration @ ffc5d65f

-Subproject commit 4d703a2dd39ec0c2b71bbbbda8900588c4e360bd
+Subproject commit ffc5d65f9f0f0e825688177425e526131aa84631

AssignmentChecker/.idea/jsLinters/eslint.xml

+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="EslintConfiguration">
+    <option name="fix-on-save" value="true" />
+  </component>
+</project>
\ No newline at end of file

AssignmentChecker/package.json

@@ -22,9 +22,10 @@
     },
     "scripts"        : {
         "dotenv:build": "npx dotenv-vault local build",
+        "lint"        : "npx eslint .",
         "genversion"  : "npx genversion -s -e src/config/Version.ts",
         "build"       : "npm run genversion; npx tsc",
-        "start:dev"   : "npm run genversion; npx ts-node src/app.ts",
+        "start:dev"   : "npm run genversion; npm run lint; npx ts-node src/app.ts",
         "test"        : "echo \"Error: no test specified\" && exit 1"
     },
     "dependencies"   : {
@@ -44,16 +45,18 @@
         "yaml"             : "^2.3.2"
     },
     "devDependencies": {
-        "@types/dockerode"  : "^3.3.19",
-        "@types/fs-extra"   : "^11.0.1",
-        "@types/js-yaml"    : "^4.0.5",
-        "@types/node"       : "^18.17.1",
-        "@types/tar-stream" : "^2.2.2",
-        "dotenv-vault"      : "^1.25.0",
-        "genversion"        : "^3.1.1",
-        "pkg"               : "^5.8.1",
-        "tiny-typed-emitter": "^2.1.0",
-        "ts-node"           : "^10.9.1",
-        "typescript"        : "^5.1.6"
+        "@types/dockerode"                : "^3.3.19",
+        "@types/fs-extra"                 : "^11.0.1",
+        "@types/js-yaml"                  : "^4.0.5",
+        "@types/node"                     : "^18.17.1",
+        "@types/tar-stream"               : "^2.2.2",
+        "@typescript-eslint/eslint-plugin": "^6.10.0",
+        "@typescript-eslint/parser"       : "^6.10.0",
+        "dotenv-vault"                    : "^1.25.0",
+        "genversion"                      : "^3.1.1",
+        "pkg"                             : "^5.8.1",
+        "tiny-typed-emitter"              : "^2.1.0",
+        "ts-node"                         : "^10.9.1",
+        "typescript"                      : "^5.1.6"
     }
 }

AssignmentChecker/src/app.ts

 // Read from the .env file
-// ATTENTION : This lines MUST be the first of this file (except for the path import)
-const path = require('node:path');
-const myEnv = require('dotenv').config({
-                                           path      : path.join(__dirname, '../.env'),
-                                           DOTENV_KEY: 'dotenv://:key_f1778b6998874f6fd78c716ccef982c5595fa300f174b129eafc88ba7044d69b@dotenv.local/vault/.env.vault?environment=development'
-                                       });
-require('dotenv-expand').expand(myEnv);
+// ATTENTION : These lines MUST be the first of this file (except for the path import)
+import path = require('node:path');
+import myEnv = require('dotenv');
+import dotenvExpand = require('dotenv-expand');
+
+
+dotenvExpand.expand(myEnv.config({
+                                     path      : path.join(__dirname, '../.env'),
+                                     DOTENV_KEY: 'dotenv://:key_f1778b6998874f6fd78c716ccef982c5595fa300f174b129eafc88ba7044d69b@dotenv.local/vault/.env.vault?environment=development'
+                                 }));
+
 require('./shared/helpers/TypeScriptExtensions'); // ATTENTION : This line MUST be the second of this file
 
+
 import ClientsSharedAssignmentHelper from './sharedByClients/helpers/Dojo/ClientsSharedAssignmentHelper';
 import AssignmentValidator           from './sharedByClients/helpers/Dojo/AssignmentValidator';
 import Styles                        from './types/Style';
-import { exec }                      from 'child_process';
-import util                          from 'util';
 import HttpManager                   from './managers/HttpManager';
 import Config                        from './config/Config';
 import Icon                          from './sharedByClients/types/Icon';
 
 
 (async () => {
-    const execAsync = util.promisify(exec);
-
     HttpManager.registerAxiosInterceptor();
 
     console.log(Styles.APP_NAME(`${ Config.appName } (version {{VERSION}})`));
@@ -43,13 +44,13 @@ import Icon                          from './sharedByClients/types/Icon';
                 }
             });
 
-            assignmentValidator.events.on('finished', (success: boolean, exitCode: number) => {
+            assignmentValidator.events.on('finished', (success: boolean) => {
                 success ? resolve() : reject();
             });
 
             assignmentValidator.run();
         });
-    } catch ( error ) { }
+    } catch ( error ) { /* empty */ }
 
     ClientsSharedAssignmentHelper.displayExecutionResults(assignmentValidator, `The assignment is ready to be published.`, Styles);
 

AssignmentChecker/src/managers/HttpManager.ts

@@ -57,7 +57,7 @@ class HttpManager {
         }, (error) => {
             if ( error.response ) {
                 if ( error.response.status === StatusCodes.METHOD_NOT_ALLOWED && error.response.data ) {
-                    const data: DojoBackendResponse<{}> = error.response.data;
+                    const data: DojoBackendResponse<void> = error.response.data;
 
                     switch ( data.code ) {
                         case DojoStatusCode.CLIENT_NOT_SUPPORTED:

shared @ 101cc268

-Subproject commit 4a5eb68209ae9204b6d4cc8020bd62cf6a5be989
+Subproject commit 101cc26895eb0b5fe97e03bb96039e0cddd94391

sharedByClients @ 39ababf4

-Subproject commit dc12d17660bf9e92656c6abcb24ec7ce6ab3d675
+Subproject commit 39ababf437cd738b45e07743455be7588640d5c9