Sonar => Resolve issues

config/ClientsSharedConfig.ts

@@ -21,28 +21,28 @@ class ClientsSharedConfig {
 
 
     constructor() {
-        this.apiURL = process.env.API_URL || '';
+        this.apiURL = process.env.API_URL ?? '';
 
         this.assignment = {
-            filename   : process.env.ASSIGNMENT_FILENAME || '',
-            neededFiles: JSON.parse(process.env.EXERCISE_NEEDED_FILES || '[]')
+            filename   : process.env.ASSIGNMENT_FILENAME ?? '',
+            neededFiles: JSON.parse(process.env.EXERCISE_NEEDED_FILES ?? '[]')
         };
 
         this.gitlab = {
             dojoAccount: {
-                id      : Number(process.env.GITLAB_DOJO_ACCOUNT_ID) || -1,
-                username: process.env.GITLAB_DOJO_ACCOUNT_USERNAME || ''
+                id      : Number(process.env.GITLAB_DOJO_ACCOUNT_ID ?? -1),
+                username: process.env.GITLAB_DOJO_ACCOUNT_USERNAME ?? ''
             }
         };
 
         this.dockerCompose = {
-            projectName: process.env.DOCKER_COMPOSE_PROJECT_NAME || ''
+            projectName: process.env.DOCKER_COMPOSE_PROJECT_NAME ?? ''
         };
 
-        this.exerciseResultsFolderMaxSizeInBytes = Number(process.env.EXERCISE_RESULTS_FOLDER_MAX_SIZE_IN_BYTES || 0);
+        this.exerciseResultsFolderMaxSizeInBytes = Number(process.env.EXERCISE_RESULTS_FOLDER_MAX_SIZE_IN_BYTES ?? 0);
 
         this.filenames = {
-            results: process.env.EXERCISE_RESULTS_FILENAME || ''
+            results: process.env.EXERCISE_RESULTS_FILENAME ?? ''
         };
     }
 }

helpers/Dojo/AssignmentValidator.ts

@@ -196,7 +196,7 @@ class AssignmentValidator {
                 });
 
                 dockerComposeValidation.on('exit', code => {
-                    code !== null && code === 0 ? resolve() : reject();
+                    code !== null && code === 0 ? resolve() : reject(code);
                 });
             });
         } catch ( error ) {
@@ -271,7 +271,7 @@ class AssignmentValidator {
                 });
 
                 exerciseDockerCompose.events.on('finished', (_success: boolean, exitCode: number) => {
-                    exitCode !== 0 ? resolve() : reject();
+                    exitCode !== 0 ? resolve() : reject(exitCode);
                 });
 
                 exerciseDockerCompose.run(this.doDown);

models/Exercise.ts

 import GitlabRepository from '../../shared/types/Gitlab/GitlabRepository';
-import { CommitSchema } from '@gitbeaker/rest';
+import * as Gitlab      from '@gitbeaker/rest';
 import User             from './User';
 import Assignment       from './Assignment';
 
@@ -18,7 +18,7 @@ interface Exercise {
     assignment: Assignment | undefined;
 
     isCorrection: boolean;
-    correctionCommit: CommitSchema | undefined;
+    correctionCommit: Gitlab.CommitSchema | undefined;
 }