Lint => Update eslint

NodeApp/.eslintignore

-dist
-node_modules
-.gitlab-ci
\ No newline at end of file

NodeApp/.eslintrc.json

-{
-    "root"   : true,
-    "parser" : "@typescript-eslint/parser",
-    "plugins": [
-        "@typescript-eslint"
-    ],
-    "extends": [
-        "eslint:recommended",
-        "plugin:@typescript-eslint/recommended"
-    ]
-}
\ No newline at end of file

NodeApp/.idea/jsLinters/eslint.xml

 <?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
   <component name="EslintConfiguration">
+    <custom-configuration-file used="false" path="./eslint.config.js" />
     <option name="fix-on-save" value="true" />
   </component>
 </project>
\ No newline at end of file

NodeApp/eslint.config.js

+// @ts-check
+// @formatter:off
+
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+
+
+export default tseslint.config({
+                                   ignores: [ 'dist/*', 'node_modules/*', '.gitlab-ci.yml', 'eslint.config.js' ]
+                               }, eslint.configs.recommended, ...tseslint.configs.recommendedTypeChecked, {
+                                   languageOptions: {
+                                       parserOptions: {
+                                           project: true, tsconfigRootDir: import.meta.dirname
+                                       }
+                                   }
+                               }, {
+                                   plugins: {
+                                       '@typescript-eslint': tseslint.plugin
+                                   }, rules: {
+                                       '@typescript-eslint/no-unsafe-assignment': 'off',
+                                       '@typescript-eslint/no-unsafe-member-access': 'off',
+                                       '@typescript-eslint/require-await': 'off',
+                                       '@typescript-eslint/restrict-template-expressions': 'off',
+                                   }
+                               });
\ No newline at end of file

NodeApp/package-lock.json

@@ -51,7 +51,7 @@
                 "pkg": "^5.8.1",
                 "tiny-typed-emitter": "^2.1.0",
                 "tsx": "^4.7.1",
-                "typescript": "^5.4.2",
+                "typescript": "^5.4.3",
                 "typescript-eslint": "^7.4.0"
             }
         },

NodeApp/package.json

@@ -34,14 +34,14 @@
         "test"        : "echo \"Error: no test specified\" && exit 1"
     },
     "dependencies"   : {
-        "@gitbeaker/rest"           : "^40.0.1",
-        "@gitbeaker/core"           : "^40.0.1",
-        "@gitbeaker/requester-utils": "^40.0.1",
+        "@gitbeaker/rest"           : "^40.0.2",
+        "@gitbeaker/core"           : "^40.0.2",
+        "@gitbeaker/requester-utils": "^40.0.2",
         "appdata-path"              : "^1.0.0",
-        "axios"                     : "^1.6.5",
+        "axios"                     : "^1.6.8",
         "boxen"                     : "^5.1.2",
         "chalk"                     : "^4.1.2",
-        "commander"                 : "^11.1.0",
+        "commander"                 : "^12.0.0",
         "dotenv"                    : "^16.3.1",
         "dotenv-expand"             : "^10.0.0",
         "form-data"                 : "^4.0.0",
@@ -52,28 +52,28 @@
         "jsonwebtoken"              : "^8.5.1",
         "open"                      : "^8.4.2",
         "ora"                       : "^5.4.1",
-        "semver"                    : "^7.5.4",
-        "tar-stream"                : "^3.1.6",
-        "winston"                   : "^3.11.0",
+        "semver"                    : "^7.6.0",
+        "tar-stream"                : "^3.1.7",
+        "winston"                   : "^3.13.0",
         "winston-transport"         : "^4.7.0",
-        "yaml"                      : "^2.3.4",
+        "yaml"                      : "^2.4.1",
         "zod"                       : "^3.22.4",
-        "zod-validation-error"      : "^3.0.0"
+        "zod-validation-error"      : "^3.0.3"
     },
     "devDependencies": {
         "@types/fs-extra"    : "^11.0.4",
         "@types/inquirer"    : "^8.2.10",
         "@types/jsonwebtoken": "^8.5.9",
-        "@types/node"                     : "^18.19.2",
-        "@types/semver"                   : "^7.5.6",
+        "@types/node"        : "^18.19.26",
+        "@types/semver"      : "^7.5.8",
         "@types/tar-stream"  : "^3.1.3",
-        "@typescript-eslint/eslint-plugin": "^6.18.1",
-        "@typescript-eslint/parser"       : "^6.18.1",
         "dotenv-vault"       : "^1.25.0",
+        "eslint"             : "^8.57.0",
         "genversion"         : "^3.2.0",
         "pkg"                : "^5.8.1",
+        "tiny-typed-emitter" : "^2.1.0",
         "tsx"                : "^4.7.1",
-        "typescript"         : "^5.4.2",
-        "typescript"                      : "^5.3.3"
+        "typescript"         : "^5.4.3",
+        "typescript-eslint"  : "^7.4.0"
     }
 }

NodeApp/src/commander/CommanderApp.ts

@@ -96,7 +96,7 @@ ${ TextStyle.CODE(' dojo upgrade ') }`, {
         if ( SharedConfig.production ) {
             const latestDojoCliVersion = stateConfigFile.getParam('latestDojoCliVersion') as string | null || '0.0.0';
             const latestDojoCliVersionNotification = stateConfigFile.getParam('latestDojoCliVersionNotification') as number | null || 0;
-            if ( semver.lt(version, latestDojoCliVersion) && (new Date()).getTime() - latestDojoCliVersionNotification >= Config.versionUpdateInformationPeriodHours * 60 * 60 * 1000 ) {
+            if ( semver.lt(version as string, latestDojoCliVersion) && (new Date()).getTime() - latestDojoCliVersionNotification >= Config.versionUpdateInformationPeriodHours * 60 * 60 * 1000 ) {
                 console.log(boxen(`The ${ latestDojoCliVersion } version of the DojoCLI is available.
 You can upgrade the DojoCLI by executing this command: 
 ${ TextStyle.CODE(' dojo upgrade ') }`, {

NodeApp/src/commander/exercise/subcommands/ExerciseCorrectionCommand.ts

@@ -68,7 +68,7 @@ class ExerciseCorrectionCommand extends CommanderCommand {
 
         console.log(TextStyle.URL(correctionUrl));
 
-        open(correctionUrl).then();
+        await open(correctionUrl);
     }
 }
 

NodeApp/src/config/LocalConfigFile.ts

@@ -32,7 +32,7 @@ class LocalConfigFile {
         }
     }
 
-    getParam(key: string): unknown | null {
+    getParam(key: string): unknown {
         const value = key in this._config ? this._config[key] : null;
         if ( value === null ) {
             return null;

NodeApp/src/helpers/AutoCompletionHelper.ts

@@ -27,7 +27,7 @@ async function askConfirmation(msg: string): Promise<boolean> {
                                       message: msg,
                                       type   : 'confirm',
                                       default: false
-                                  })).confirm;
+                                  })).confirm as boolean;
 }
 
 // Returns false, when the renaming is interrupted

NodeApp/src/helpers/Dojo/ExerciseRunHelper.ts

@@ -256,7 +256,7 @@ class ExerciseRunHelper {
                 });
 
                 this.exerciseResultsValidation.events.on('finished', (success: boolean, exitCode: number) => {
-                    success || exitCode === ExerciseCheckerError.EXERCISE_RESULTS_FOLDER_TOO_BIG ? resolve() : reject();
+                    success || exitCode === ExerciseCheckerError.EXERCISE_RESULTS_FOLDER_TOO_BIG.valueOf() ? resolve() : reject();
                 });
 
                 this.exerciseResultsValidation.run();
@@ -271,7 +271,7 @@ class ExerciseRunHelper {
      * Step 4: Display results + Volume location
      * @private
      */
-    private async displayResults() {
+    private displayResults() {
         const info = chalk.magenta.bold.italic;
         ClientsSharedExerciseHelper.displayExecutionResults(this.exerciseResultsValidation.exerciseResults, this.exerciseDockerCompose.exitCode, {
             INFO   : info,
@@ -285,7 +285,7 @@ class ExerciseRunHelper {
             await this.checkRequirements();
             await this.runDockerCompose();
             await this.getResults();
-            await this.displayResults();
+            this.displayResults();
         } catch ( error ) {
             return;
         }

NodeApp/src/managers/DojoBackendManager.ts

@@ -25,7 +25,7 @@ class DojoBackendManager {
                         spinner.fail(`No pipeline found for this assignment.`);
                         break;
                     case DojoStatusCode.ASSIGNMENT_PUBLISH_PIPELINE_FAILED:
-                        spinner.fail(error.response?.data?.message ?? `Last pipeline status is not "${ GitlabPipelineStatus.SUCCESS }".`);
+                        spinner.fail((error.response?.data?.message as string | undefined) ?? `Last pipeline status is not "${ GitlabPipelineStatus.SUCCESS }".`);
                         break;
                     case DojoStatusCode.EXERCISE_CORRECTION_ALREADY_EXIST:
                         spinner.fail(`This exercise is already labelled as a correction. If you want to update it, please use the update command.`);
@@ -199,7 +199,7 @@ class DojoBackendManager {
         }
 
         try {
-            const axiosFunction = isUpdate ? axios.patch : axios.post;
+            const axiosFunction = isUpdate ? axios.patch.bind(axios) : axios.post.bind(axios);
             const route = isUpdate ? ApiRoute.ASSIGNMENT_CORRECTION_UPDATE : ApiRoute.ASSIGNMENT_CORRECTION_LINK;
 
             await axiosFunction(DojoBackendHelper.getApiUrl(route, {

NodeApp/src/managers/HttpManager.ts

@@ -26,9 +26,11 @@ class HttpManager {
             }
 
             if ( config.url && (config.url.indexOf(ClientsSharedConfig.apiURL) !== -1) ) {
+
+
                 config.headers['Accept-Encoding'] = 'gzip';
 
-                if ( config.data && Object.keys(config.data).length > 0 ) {
+                if ( config.data && Object.keys(config.data as { [key: string]: unknown }).length > 0 ) {
                     config.headers['Content-Type'] = 'multipart/form-data';
                 }
 
@@ -62,10 +64,10 @@ class HttpManager {
             const data: DojoBackendResponse<void> = error.response.data as DojoBackendResponse<void>;
 
             switch ( data.code ) {
-                case DojoStatusCode.CLIENT_NOT_SUPPORTED:
+                case DojoStatusCode.CLIENT_NOT_SUPPORTED.valueOf():
                     this.requestError('Client not recognized by the server. Please contact the administrator.');
                     break;
-                case DojoStatusCode.CLIENT_VERSION_NOT_SUPPORTED:
+                case DojoStatusCode.CLIENT_VERSION_NOT_SUPPORTED.valueOf():
                     this.requestError(`CLI version not anymore supported by the server. Please update the CLI by executing this command:\n${ TextStyle.CODE(' dojo upgrade ') }`);
                     break;
                 default:
@@ -80,10 +82,10 @@ class HttpManager {
 
             if ( errorCustomCode === error.response.status ) {
                 switch ( error.response.status ) {
-                    case StatusCodes.UNAUTHORIZED:
+                    case StatusCodes.UNAUTHORIZED.valueOf():
                         this.requestError('Session expired or does not exist. Please login again.');
                         break;
-                    case StatusCodes.FORBIDDEN:
+                    case StatusCodes.FORBIDDEN.valueOf():
                         this.requestError('Forbidden access.');
                         break;
                     default:
@@ -114,8 +116,8 @@ class HttpManager {
 
             return response;
         }, async error => {
-            if ( error.response ) {
-                const isFromApi = error.response.config.url && error.response.config.url.indexOf(ClientsSharedConfig.apiURL) !== -1;
+            if ( error instanceof AxiosError && error.response ) {
+                const isFromApi = error.response.config.url !== undefined && error.response.config.url.indexOf(ClientsSharedConfig.apiURL) !== -1;
 
                 this.apiMethodNotAllowed(error, isFromApi);
                 this.apiAuthorizationError(error, isFromApi);

NodeApp/src/managers/SessionManager.ts

@@ -134,7 +134,7 @@ class SessionManager {
                                           message: `${ chalk.green('?') } Please paste the Gitlab code here`,
                                           mask   : '*',
                                           prefix : '   '
-                                      })).code;
+                                      })).code as string;
     }
 
     private getGitlabCodeFromGraphicEnvironment(): Promise<string> {
@@ -156,7 +156,7 @@ class SessionManager {
                                          text  : `Waiting for user to authorize the application in his web browser. If the browser does not open automatically, please go to : ${ Config.login.gitlab.url.code }`,
                                          indent: 4
                                      }).start();
-                open(Config.login.gitlab.url.code).then();
+                void open(Config.login.gitlab.url.code).then();
             });
             loginServer.events.on('error', (error: string) => {
                 currentSpinner.fail(`Login server error: ${ error }`);

shared @ 021300d2

-Subproject commit 77badeab872fc6ce5873c1182b428e9410525f95
+Subproject commit 021300d29473dee2ad229384d22a521c0e5c14aa

sharedByClients @ 8514d5ef

-Subproject commit acba6304b6fea92d473ceba1a66adacd06ca00c5
+Subproject commit 8514d5ef589a8aa34e4d2260c618781d81368c22